E2E POC for python telemetry for connect logs - #581
Merged
saishreeeee merged 269 commits intoJun 10, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
saishreeeee
requested review from
deeksha-db,
gopalldb,
jackyhu-db,
jayantsing-db,
jprakash-db,
madhav-db,
samikshya-db,
shivam2680 and
vikrantpuppala
as code owners
June 3, 2025 02:51
saishreeeee
marked this pull request as draft
June 3, 2025 02:51
saishreeeee
marked this pull request as ready for review
June 3, 2025 05:05
vikrantpuppala
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
can we break down this PR further please? let's start with simple connect logs, then error logs and then latency logs
Sorry, something went wrong.
Comment thread
src/databricks/sql/client.py
Outdated
Comment thread
src/databricks/sql/client.py
Outdated
Comment thread
src/databricks/sql/client.py
Outdated
Comment thread
src/databricks/sql/client.py
Outdated
Comment thread
src/databricks/sql/client.py
Outdated
Comment thread
src/databricks/sql/client.py
Outdated
Comment thread
src/databricks/sql/exc.py
Outdated
Comment thread
src/databricks/sql/client.py
Outdated
Comment thread
src/databricks/sql/telemetry/telemetry_client.py
Outdated
Comment thread
src/databricks/sql/telemetry/telemetry_client.py
Outdated
Comment thread
src/databricks/sql/telemetry/telemetry_client.py
Outdated
Comment thread
src/databricks/sql/telemetry/telemetry_client.py
Outdated
Comment thread
src/databricks/sql/telemetry/telemetry_client.py
Outdated
Copy link
Copy Markdown
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main). |
Sorry, something went wrong.
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
…unit tests accordingly Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
Comment thread
src/databricks/sql/telemetry/telemetry_client.py
Outdated
Comment thread
src/databricks/sql/telemetry/telemetry_client.py
Outdated
Comment thread
src/databricks/sql/telemetry/models/event.py
Outdated
Comment thread
src/databricks/sql/telemetry/telemetry_client.py
Outdated
Comment thread
src/databricks/sql/telemetry/telemetry_client.py
…etry_client does not return a telemetry client Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
jprakash-db
reviewed
Jun 9, 2025
Comment thread
src/databricks/sql/telemetry/telemetry_client.py
Outdated
Comment thread
src/databricks/sql/telemetry/telemetry_client.py
Outdated
Comment thread
src/databricks/sql/telemetry/telemetry_client.py
Outdated
Comment thread
src/databricks/sql/telemetry/telemetry_client.py
Outdated
Comment thread
src/databricks/sql/telemetry/telemetry_client.py
Outdated
Comment thread
src/databricks/sql/telemetry/telemetry_client.py
Outdated
Comment thread
tests/unit/test_telemetry.py
Comment thread
tests/unit/test_telemetry.py
Outdated
Comment thread
tests/unit/test_telemetry.py
Comment thread
tests/unit/test_telemetry.py
Outdated
…as constants, added callback function while submitting request to executor, changed del to pop Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
jprakash-db
approved these changes
Jun 10, 2025
jprakash-db
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM. Thanks for making the changes.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Added TelemetryClient and TelemetryClientFactory
Added functionality to export initial telemetry logs
How is this tested?
Added unit tests to check the functionality of telemetry client and telemetry client factory
Ran a query that triggered the export of initital telemetry log, verified that the log was present in the target table
Related Tickets & Documents
PECOBLR-457