Add ignore_transactions config to disable transaction operations - #711
Merged
vikrantpuppala merged 1 commit intoNov 20, 2025
Merged
Add ignore_transactions config to disable transaction operations#711vikrantpuppala merged 1 commit into
vikrantpuppala merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Introduces a new `ignore_transactions` configuration parameter (default: True) to control transaction-related behavior in the Connection class. When ignore_transactions=True (default): - commit(): no-op, returns immediately - rollback(): raises NotSupportedError with message "Transactions are not supported on Databricks" - autocommit setter: no-op, returns immediately When ignore_transactions=False: - All transaction methods execute normally Changes: - Added ignore_transactions parameter to Connection.__init__() with default value True - Modified commit(), rollback(), and autocommit setter to check ignore_transactions flag - Updated unit tests to pass ignore_transactions=False when testing transaction functionality - Updated e2e transaction tests to pass ignore_transactions=False - Added three new unit tests to verify ignore_transactions
jayantsing-db
had a problem deploying
to
azure-prod
November 20, 2025 09:05 — with 
GitHub Actions
Failure
jayantsing-db
had a problem deploying
to
azure-prod
November 20, 2025 09:05 — with
GitHub Actions
Failure
Copy link
Copy Markdown
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main). |
Sorry, something went wrong.
vikrantpuppala
approved these changes
Nov 20, 2025
Copy link
Copy Markdown
Contributor
Author
|
Hey @vikrantpuppala, just an FYI, when the flag is set to false, the autocommit getter will return true. I wasn’t entirely sure which default made the most sense, but true seems more appropriate. Airflow jobs shouldn’t break with this behavior, but could you double-check as well? I’ve already verified on my end. |
Sorry, something went wrong.
samikshya-db
pushed a commit
that referenced
this pull request
Nov 25, 2025
Introduces a new `ignore_transactions` configuration parameter (default: True) to control transaction-related behavior in the Connection class. When ignore_transactions=True (default): - commit(): no-op, returns immediately - rollback(): raises NotSupportedError with message "Transactions are not supported on Databricks" - autocommit setter: no-op, returns immediately When ignore_transactions=False: - All transaction methods execute normally Changes: - Added ignore_transactions parameter to Connection.__init__() with default value True - Modified commit(), rollback(), and autocommit setter to check ignore_transactions flag - Updated unit tests to pass ignore_transactions=False when testing transaction functionality - Updated e2e transaction tests to pass ignore_transactions=False - Added three new unit tests to verify ignore_transactions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new ignore_transactions configuration parameter (default: True) to control transaction-related behavior in the Connection class.
When ignore_transactions=True (default):
When ignore_transactions=False:
Changes:
What type of PR is this?
Description
How is this tested?
Related Tickets & Documents