FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixed the exception handler close() on _TelemetryClientHolder by msrathore-db · Pull Request #723 · databricks/databricks-sql-python · GitHub

/ databricks-sql-python Public

Fixed the exception handler close() on _TelemetryClientHolder - #723

Merged
msrathore-db merged 1 commit into
mainfrom
telemetry-close-fix
Jan 1, 2026
ConversationCommits (1)ChecksFiles changed
Merged

Fixed the exception handler close() on _TelemetryClientHolder #723
msrathore-db merged 1 commit into
mainfrom
telemetry-close-fix

Conversation

msrathore-db commented Dec 26, 2025

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other

Description

Fixed the exception handler close() on _TelemetryClientHolder objects instead of accessing the client inside them.

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Related Tickets & Documents

Fixed the exception handler calls close() on _TelemetryClientHolder o…
cfecce1 
…bjects instead of accessing the client inside them.

github-actions Bot commented Dec 26, 2025

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

nikhilsuri-db commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

Should we add more configuration like check_untyped_defs disallow_untyped_defs warn_return_any warn_unused_ignores in mypy tool to identify such issues early or at least let the developer know?

samikshya-db commented Dec 30, 2025

Copy link
Copy Markdown
Contributor

Sorry, might not be aware of this - Can you give more context on this change and how was this caught?

msrathore-db commented Dec 30, 2025

Copy link
Copy Markdown
Contributor Author

Sorry, might not be aware of this - Can you give more context on this change and how was this caught?

Was testing something with python connector but got an error from the server, which led to seeing this exception. The close() didn't exist in the class so made this small fix

samikshya-db approved these changes Dec 31, 2025
View reviewed changes

samikshya-db left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

thanks for fixing this, @msrathore-db !

msrathore-db merged commit 9b4e577 into main Jan 1, 2026
35 of 36 checks passed
samikshya-db mentioned this pull request Jan 14, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

samikshya-db samikshya-db approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL