created util method to normalise http protocol in http path by nikhilsuri-db · Pull Request #724 · databricks/databricks-sql-python · GitHub

What type of PR is this?

Refactor
Feature
Bug Fix
Other

Description

Problem
Feature flag and telemetry endpoints were double-prepending https:// when server_hostname already included the protocol, causing https://https://host.com URLs. This broke telemetry for dbt-databricks users who configure hostnames with https:// prefix.

Solution
Added normalize_host_with_protocol() utility to handle protocol normalization
Updated feature flag and telemetry clients to use: normalize_host_with_protocol(host) + "/path"
Handles hostnames with/without protocol and trailing slashes

How is this tested?

Unit tests
E2E Tests
Manually
N/A

Related Tickets & Documents

#709

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>

LGTM with minor comments, thanks!

Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>

LGTM. Thanks for making the changes

nikhilsuri-db self-assigned this Dec 30, 2025

nikhilsuri-db had a problem deploying to azure-prod December 30, 2025 04:13 — with GitHub Actions Failure

nikhilsuri-db temporarily deployed to azure-prod December 30, 2025 04:13 — with GitHub Actions Inactive

nikhilsuri-db had a problem deploying to azure-prod December 30, 2025 04:14 — with GitHub Actions Failure

nikhilsuri-db temporarily deployed to azure-prod December 30, 2025 04:23 — with GitHub Actions Inactive

nikhilsuri-db had a problem deploying to azure-prod December 30, 2025 04:23 — with GitHub Actions Failure

nikhilsuri-db added 3 commits December 30, 2025 09:54

created util method to normalise http protocol in http path

14915d2

Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>

Added impacted files using util method

81ec814

Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>

Fixed linting issues

ef4f92c

Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>

nikhilsuri-db force-pushed the PECOBLR-1446 branch from 07cb5fd to ef4f92c Compare December 30, 2025 04:24

nikhilsuri-db had a problem deploying to azure-prod December 30, 2025 04:24 — with GitHub Actions Failure

nikhilsuri-db temporarily deployed to azure-prod December 30, 2025 04:24 — with GitHub Actions Inactive

fixed broken test with mock host string

e982615

Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>

nikhilsuri-db temporarily deployed to azure-prod December 30, 2025 05:31 — with GitHub Actions Inactive

mocked http client

5ae79ce

Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>

nikhilsuri-db temporarily deployed to azure-prod December 30, 2025 09:32 — with GitHub Actions Inactive

nikhilsuri-db had a problem deploying to azure-prod December 30, 2025 09:32 — with GitHub Actions Failure

samikshya-db approved these changes Dec 30, 2025

View reviewed changes

Comment thread src/databricks/sql/common/url_utils.py

Comment thread src/databricks/sql/common/url_utils.py

made case sensitive check in url utils

cca26eb

Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>

nikhilsuri-db temporarily deployed to azure-prod December 31, 2025 04:48 — with GitHub Actions Inactive

linting issue resolved

a5c698c

Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>

nikhilsuri-db temporarily deployed to azure-prod December 31, 2025 05:32 — with GitHub Actions Inactive

removed unnecessary md files

5f9954f

Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>

nikhilsuri-db had a problem deploying to azure-prod December 31, 2025 05:59 — with GitHub Actions Failure

made test readbale

23af8e2

Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>

samikshya-db reviewed Dec 31, 2025

View reviewed changes

Comment thread src/databricks/sql/common/url_utils.py

nikhilsuri-db temporarily deployed to azure-prod December 31, 2025 07:17 — with GitHub Actions Inactive

samikshya-db self-requested a review December 31, 2025 09:30

nikhilsuri-db temporarily deployed to azure-prod January 1, 2026 06:22 — with GitHub Actions Inactive

changes done in auth util as well as sea http

f8dad10

Signed-off-by: Nikhil Suri <nikhil.suri@databricks.com>

nikhilsuri-db force-pushed the PECOBLR-1446 branch from e722c6d to f8dad10 Compare January 1, 2026 06:23

nikhilsuri-db temporarily deployed to azure-prod January 1, 2026 06:23 — with GitHub Actions Inactive

samikshya-db approved these changes Jan 1, 2026

View reviewed changes

jprakash-db approved these changes Jan 5, 2026

View reviewed changes

nikhilsuri-db merged commit 946a265 into main Jan 5, 2026
36 checks passed

created util method to normalise http protocol in http path by nikhilsuri-db · Pull Request #724 · databricks/databricks-sql-python · GitHub

Uh oh!

created util method to normalise http protocol in http path - #724

created util method to normalise http protocol in http path#724
nikhilsuri-db merged 10 commits into
mainfrom
PECOBLR-1446

nikhilsuri-db commented Dec 30, 2025 •
edited
Loading

Uh oh!

Uh oh!

github-actions Bot commented Dec 30, 2025

Uh oh!

github-actions Bot commented Dec 30, 2025

Uh oh!

github-actions Bot commented Dec 30, 2025

Uh oh!

github-actions Bot commented Dec 30, 2025

Uh oh!

samikshya-db left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jan 1, 2026

Uh oh!

jprakash-db left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

created util method to normalise http protocol in http path by nikhilsuri-db · Pull Request #724 · databricks/databricks-sql-python · GitHub

Uh oh!

created util method to normalise http protocol in http path - #724

created util method to normalise http protocol in http path#724nikhilsuri-db merged 10 commits intomaindatabricks/databricks-sql-python:mainfrom PECOBLR-1446databricks/databricks-sql-python:PECOBLR-1446Copy head branch name to clipboard

Conversation

nikhilsuri-db commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

Description

How is this tested?

Related Tickets & Documents

Uh oh!

github-actions Bot commented Dec 30, 2025

Uh oh!

github-actions Bot commented Dec 30, 2025

Uh oh!

github-actions Bot commented Dec 30, 2025

Uh oh!

github-actions Bot commented Dec 30, 2025

Uh oh!

samikshya-db left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jan 1, 2026

Uh oh!

jprakash-db left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

created util method to normalise http protocol in http path#724
nikhilsuri-db merged 10 commits into
mainfrom
PECOBLR-1446

nikhilsuri-db commented Dec 30, 2025 •
edited
Loading