FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bump thrift to fix deprecation warning by Korijn · Pull Request #733 · databricks/databricks-sql-python · GitHub

/ databricks-sql-python Public

Bump thrift to fix deprecation warning - #733

Merged
jprakash-db merged 2 commits into
databricks:mainfrom
Korijn:bump-thrift
Apr 20, 2026
ConversationCommits (2)ChecksFiles changed
Merged

Bump thrift to fix deprecation warning#733
jprakash-db merged 2 commits into
databricks:mainfrom
Korijn:bump-thrift

Conversation

Korijn commented Jan 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • Bug Fix

Description

Thrift v0.22.0 has addressed this warning which is constantly being emitted when using dbt-databricks:

WARNING:thrift.transport.sslcompat:using legacy validation callback

How is this tested?

  • Unit tests
  • E2E Tests

Related Tickets & Documents

Closes #695

Bump thrift to fix deprecation warning
6cb4293 
Signed-off-by: Korijn van Golen <k.vangolen@mapiq.com>
Korijn mentioned this pull request Jan 28, 2026
Closed

Korijn commented Jan 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Is anyone available for reviewing this PR and kicking off the CI workflows?

@jprakash-db
@msrathore-db
@samikshya-db

jprakash-db commented Jan 31, 2026

Copy link
Copy Markdown
Contributor

@Korijn Looks like some unrelated tests are failling. I think something is broken on main branch. Will raise with concerned person to fix it

jprakash-db commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

The tests are fixed on main. Please merge main into this branch

Korijn commented Mar 16, 2026

Copy link
Copy Markdown
Contributor Author

The tests are fixed on main. Please merge main into this branch

Done

JordyForNow commented Mar 30, 2026

Copy link
Copy Markdown

when will this be reviewed?

Korijn commented Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

This PR makes me feel like Dependabot! 😁

tweavers commented Apr 16, 2026

Copy link
Copy Markdown

bump?

jprakash-db enabled auto-merge (squash) April 20, 2026 03:37
jprakash-db merged commit 9031863 into databricks:main Apr 20, 2026

jprakash-db commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Done

vikrantpuppala mentioned this pull request Apr 21, 2026
Merged
3 tasks
vikrantpuppala added a commit that referenced this pull request Apr 21, 2026
Fix dependency_manager: handle PEP 440 ~= compatible release syntax (#…
b088a35 
…776)

The _extract_versions_from_specifier function stripped a single `~`
character from constraint strings, which corrupted PEP 440 compatible
release syntax (`~=`) by leaving a stray `=`. For example,
`thrift = "~=0.22.0"` produced the invalid constraint
`thrift>==0.22.0,<=0.23.0`, breaking every PR's "Unit Tests (min deps)"
job since #733 was merged.

Add an explicit branch for `~=` that strips both characters before
extracting the minimum version. The Poetry-style single `~` branch is
preserved for backward compatibility.

Co-authored-by: Isaac

Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
KiranAtmala mentioned this pull request Apr 30, 2026
Closed
JordyForNow mentioned this pull request May 7, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jprakash-db jprakash-db approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade thrift dependency to address WARNING:thrift.transport.sslcompat:using legacy validation callback

4 participants

Back | FazBrowse Home | New Git URL