FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[ES-1717039] Fix 60 seconds delay in gov cloud connections + Fix PR check failures in the repo by samikshya-db · Pull Request #735 · databricks/databricks-sql-python · GitHub

/ databricks-sql-python Public

[ES-1717039] Fix 60 seconds delay in gov cloud connections + Fix PR check failures in the repo - #735

Merged
samikshya-db merged 8 commits into
mainfrom
samikshya-chand_data/newV
Feb 5, 2026
ConversationCommits (8)ChecksFiles changed
Merged

[ES-1717039] Fix 60 seconds delay in gov cloud connections + Fix PR check failures in the repo#735
samikshya-db merged 8 commits into
mainfrom
samikshya-chand_data/newV

Conversation

samikshya-db commented Feb 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other

Description

Customer Issue : There was delay of 60 seconds when user from gov-cloud connects to the driver. This was because connector service is still not deployed to gov-cloud. And, the retry mechanism indicated feature flag endpoint to retry 404 too. There were 5 retries with ~10 second wait for each.

  • Bug 1 : There are different behavior for 404 error code in each command types- in case of OTHER (i.e., commands other than execute, getoeration, close etc.) - we retry even for 404! Hence - In case of featureFlag endpoint, we were retrying for 404 too. This is not expected and we should not retry for 404.
  • Bug 2 : [Unsure if this is a bug, I am not fixing this in the PR, but will start a discussiong with the team]. backoff calculation should have been 1s, 2s, 4s, 8s, etc. but in our code we force a minumum 10 second wait, this causes ~60 second delay rather than a ~25 second delay.

Also, note : this PR fixes github action failures because of a flaky new poetry version

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Related Tickets & Documents

github-actions Bot commented Feb 4, 2026

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

samikshya-db force-pushed the samikshya-chand_data/newV branch from 41c4f40 to 65e8587 Compare February 4, 2026 07:50

github-actions Bot commented Feb 4, 2026

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

github-actions Bot commented Feb 4, 2026

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

github-actions Bot commented Feb 4, 2026

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

github-actions Bot commented Feb 4, 2026

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

samikshya-db marked this pull request as ready for review February 4, 2026 08:15

github-actions Bot commented Feb 4, 2026

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

samikshya-db commented Feb 4, 2026

Copy link
Copy Markdown
Contributor Author

Adding + @jayantsing-db , @vikrantpuppala to review. Thanks

vikrantpuppala approved these changes Feb 4, 2026
View reviewed changes

vikrantpuppala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

thank you!

samikshya-db changed the title Fix 60 seconds delay in gov cloud connections [ES-1717039] Fix 60 seconds delay in gov cloud connections Feb 4, 2026

github-actions Bot commented Feb 4, 2026

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

github-actions Bot commented Feb 4, 2026

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

samikshya-db changed the title [ES-1717039] Fix 60 seconds delay in gov cloud connections [ES-1717039] Fix 60 seconds delay in gov cloud connections + Fix PR check failures in the repo Feb 4, 2026

github-actions Bot commented Feb 4, 2026

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

samikshya-db merged commit cafed60 into main Feb 5, 2026
35 of 36 checks passed
samikshya-db deleted the samikshya-chand_data/newV branch February 5, 2026 05:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vikrantpuppala vikrantpuppala approved these changes
jayantsing-db Awaiting requested review from jayantsing-db

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL