FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix inline list parameter rendering for IN clauses by fatkobra · Pull Request #773 · databricks/databricks-sql-python · GitHub

Fix inline list parameter rendering for IN clauses - #773

Open
fatkobra wants to merge 2 commits into
databricks:mainfrom
fatkobra:Fix-inline-list-param-rendering-for-IN-clauses
Open

Fix inline list parameter rendering for IN clauses#773
fatkobra wants to merge 2 commits into
databricks:mainfrom
fatkobra:Fix-inline-list-param-rendering-for-IN-clauses

Conversation

Copy link
Copy Markdown

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other

Description

Fixes #629
Closes #629

Summary

  • add regression tests for inline list parameters used in IN clauses
  • render top-level inline list parameters as (…) instead of ARRAY(…)
  • keep nested sequence escaping behavior unchanged

How is this tested?

  • poetry run python -m pytest tests/unit/test_param_escaper.py

  • poetry run python -m pytest tests/unit/test_parameters.py tests/unit/test_param_escaper.py

  • poetry run python -m pytest tests/unit

  • poetry run python -m black src tests --check

  • Unit tests

  • E2E Tests

  • Manually

  • N/A

Related Tickets & Documents

Closes #629

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compiled sql for an input list parameter results in incorrect syntax in 4.0.4

1 participant


Back | FazBrowse Home | New Git URL