FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(bots): accept CONTRIBUTOR in engineer-followup comment-path gate by eric-wang-1990 · Pull Request #869 · databricks/databricks-sql-python · GitHub

/ databricks-sql-python Public

fix(bots): accept CONTRIBUTOR in engineer-followup comment-path gate #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eric-wang-1990 merged 1 commit into from
Jul 17, 2026
Conversation 3 Commits 1 Checks 54 Files changed
Merged

fix(bots): accept CONTRIBUTOR in engineer-followup comment-path gate #869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .yml  (1) All 1 file type selected
Only manifest files
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
14 changes: 10 additions & 4 deletions .github/workflows/engineer-bot-followup.yml
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,15 @@ jobs:
# - skip fork PRs — keep the model + App token out of untrusted code's reach;
# - operate only on non-fork OPEN PRs carrying the `engineer-bot` label
# (maintainer-applied opt-in; label requires triage+);
# - comment path: trusted commenters only (OWNER/MEMBER/COLLABORATOR, or a
# bot — reviewer-bot/Copilot), never the engineer-bot's own comments, and
# never a reviewer-bot reconcile loopback;
# - comment path: trusted commenters only
# (OWNER/MEMBER/COLLABORATOR/CONTRIBUTOR, or a bot — reviewer-bot/Copilot),
# never the engineer-bot's own comments, and never a reviewer-bot reconcile
# loopback. CONTRIBUTOR is included because a maintainer with PRIVATE org
# membership is reported as `author_association: CONTRIBUTOR` in the webhook
# payload (even though REST shows MEMBER) — without it, such a maintainer's
# review comments SILENTLY fail this gate and the bot never engages. Low
# risk: this path already requires a non-fork, OPEN, `engineer-bot`-labeled
# PR (a maintainer-applied opt-in);
# - labeled path: the `engineer-bot` label was just applied by a human.
if: >-
github.event.pull_request.head.repo.fork == false
Expand All @@ -47,7 +53,7 @@ jobs:
&& !startsWith(github.event.comment.user.login, 'peco-engineer-bot')
&& !contains(github.event.comment.body, '<!-- pr-review-bot:v1 reconcile -->')
&& (
contains(fromJson('["OWNER","MEMBER","COLLABORATOR"]'), github.event.comment.author_association)
contains(fromJson('["OWNER","MEMBER","COLLABORATOR","CONTRIBUTOR"]'), github.event.comment.author_association)
Comment thread
eric-wang-1990 marked this conversation as resolved.
|| (
github.event.comment.user.type == 'Bot'
&& (
Expand Down
Loading
Back | FazBrowse Home | New Git URL