FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

137 reorganise images by tobyhodges · Pull Request #182 · datacarpentry/image-processing · GitHub

137 reorganise images - #182

Merged
tobyhodges merged 26 commits into
gh-pagesfrom
137-reorganise-images
Feb 9, 2022
Merged

137 reorganise images#182
tobyhodges merged 26 commits into
gh-pagesfrom
137-reorganise-images

Conversation

tobyhodges commented Feb 7, 2022
edited
Loading

Copy link
Copy Markdown
Member

Fixes #137
Fixes #173
Fixes #83 (thank you to @mmeysenburg for sharing the file with me by email!)
Fixes #84

Replaces #153 because the merge conflicts were getting chaotic.

A couple things that need discussing:

  1. This PR will delete a lot of image files that do not seem to be used in the lesson anymore. It also removes all the image files in the subfolders of code/, because It believe the duplication is now unnecessary. I want to highlight:
    a. the removal of code/05-creating-histograms/plate-01.tif because we seem to be using the JPEG in the challenge now instead?
    b. the removal of code/09-challenges/colonies*.tif because again we seem to be using the JPEGs throughout the lesson now?
  2. I chose the fig/07-junk.jpg file as the main "junk" image to use in data - it does not have the black outline around it, so seems like the best source image to use in processing during the lesson?

uschille commented Feb 8, 2022

Copy link
Copy Markdown
Contributor

Thanks for all the work on this one @tobyhodges. I browsed through the episodes and everything looked fine.

One suggestion I'd have is to perhaps rename the junk- image files to shapes- or something like that.

Copy link
Copy Markdown
Member Author

Good suggestion thanks @uschille. Taken care of in adbc4a5

uschille left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks again @tobyhodges. I have updated the Markdown files for the episodes and I think all looks good.

K-Meech commented Feb 8, 2022

Copy link
Copy Markdown
Contributor

@tobyhodges Using the jpgs for the histograms and challenges episodes is due to my changes. I actually hadn't realised the tifs existed! I'll take a look at this. If the tifs are higher resolution, then we should probably use those instead...

K-Meech commented Feb 8, 2022

Copy link
Copy Markdown
Contributor

@tobyhodges I just checked - and the tif and jpg versions seem to be identical in size/content. As jpg uses lossy compression though, I think it'd be better to keep the tif versions and remove the jpg. In the long run, we could also save these as png instead to make them more consistent with the rest of the images in the lesson.

Copy link
Copy Markdown
Member Author

Thanks @uschille for finishing the renaming task.

Copy link
Copy Markdown
Member Author

@K-Meech with the last few commits I restored the TIFF versions of wellplate-02 and the colonies- files - please could you glance over those quickly in case I missed something? Then, I think this one is good to go 🤞

quist00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good on my local build.

tobyhodges merged commit 86a5a87 into gh-pages Feb 9, 2022
tobyhodges deleted the 137-reorganise-images branch February 9, 2022 06:39
tobyhodges mentioned this pull request Aug 16, 2022
zkamvar pushed a commit that referenced this pull request Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

broken link in the Introduction move example images to the "data" folder figures mislabeled titration.tif missing

4 participants


Back | FazBrowse Home | New Git URL