Repository navigation
Fix join error in the new query parser (#857) - #878
guzman-raphael merged 20 commits into
Conversation
Sorry, something went wrong.
fix datajoint#828 Used static image from shields.io; slack doesn't seem to have native support for 'badges', and other solutions ( slackin ) are nice in providing a activity count, but require running a service gateway. In any event, it's a href that works (for now).
README.md: flip gitter badge to slack (datajoint#828)
Add test for same secondary attributes between dependent tables
guzman-raphael
left a comment
There was a problem hiding this comment.
We also need to:
- Update the CHANGELOG.md and Releases_lang1.rst for this. It is really for us to be able to easily track down when bugs were patched and features introduced.
- Update nginx image to new datajoint one.
- Bump the version so we can make a new pre-release.
To make things easier, let me introduce a PR to your branch with the above included.
Sorry, something went wrong.
| need_subquery1 = need_subquery2 = bool( | ||
| (set(self.original_heading.names) & set(other.original_heading.names)) | ||
| - join_attributes) |
There was a problem hiding this comment.
This is a reasonable way to solve it with a subquery for special case. Still not a big fan of this as opposed to indexing it properly but we discussed this already. This is probably the best option given our current time constraints. We can always revisit if there is a more specific need to do so.
Sorry, something went wrong.
| assert_equal(k1, k2) | ||
|
|
||
| def test_same_secondary_attribute(self): | ||
| print(schema.Child * schema.Parent().proj()) |
There was a problem hiding this comment.
We need a better check here than just a simple print. Perhaps something that confirms the correct value is fetched.
Sorry, something went wrong.
Update `test_same_secondary_attribute` test + PR review feedback
Fix issue #857.
Fix issue #876.