Fix TypeError in tzstr for GMT/UTC without an offset - #1563
Open
prownd wants to merge 1 commit into
Open
prownd wants to merge 1 commit into
prownd wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
tzstr inverts the sign of the standard offset for GMT and UTC, but did so
unconditionally, while _parsetz leaves stdoffset as None when the string
carries no offset. tzstr("GMT"), tzstr("UTC") and gettz("GMT,4;3/4") died
with "unsupported operand type(s) for *=: 'NoneType' and 'int'".
Only invert an offset that is actually there; offset-less GMT and UTC now
fall through to tzrange's zero-offset default, as tzstr("EST") already did.
Fixes GH dateutil#1432.
Fixes GH dateutil#1402.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tzstr inverts the sign of the standard offset for GMT and UTC, but did so unconditionally, while _parsetz leaves stdoffset as None when the string carries no offset. tzstr("GMT"), tzstr("UTC") and gettz("GMT,4;3/4") died with "unsupported operand type(s) for *=: 'NoneType' and 'int'".
Only invert an offset that is actually there; offset-less GMT and UTC now fall through to tzrange's zero-offset default, as tzstr("EST") already did.
Fixes GH #1432.
Fixes GH #1402.
Summary of changes
Closes
Pull Request Checklist