Fix fuzzy parse dropping year before trailing ":" (#326) - #1566
Open
IMGillusion wants to merge 1 commit into
Open
IMGillusion wants to merge 1 commit into
IMGillusion wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
In _parse_numeric_token, extend the terminal-token branch to treat a ':' following a number as terminal too, so 4-digit years such as '2016:' are kept as year tokens instead of being dropped. When the token is followed by ':', return before consuming it so fuzzy mode reports the colon among the skipped tokens. Fixes dateutil#326
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With fuzzy=True, a 4-digit year immediately followed by : was dropped entirely, so parse("23. November 2016:", fuzzy=True) returned the default year (2026) instead of 2016.
Root cause: in _parse_numeric_token, the terminal-token branch (idx + 1 >= len_l or info.jump(...) — "year, month or day") never matched when the next token was :, so the number fell through to the fuzzy skip path and the year was lost.
Changes
Tests