Fix test requirements - #516
Merged
pganssle merged 3 commits intoNov 12, 2017
Merged
pganssle merged 3 commits into
pganssle merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
pganssle
force-pushed
the
fix_test_requirements
branch
from
c65782e to
825c660
Compare
November 12, 2017 17:22
Copy link
Copy Markdown
Contributor
|
This generally looks good. Not sure if we should still be supporting 3.2, though that decision doesn't need to be made here. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Yeah, I think after the 2.7.0 release we can drop 3.2 support, but we really should be cutting a new release soon and there's no urgent need to remove 3.2 support. |
Sorry, something went wrong.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'll need to pin pytest at version >= 2.0 if we want to use skipIf, and we'll need skipIf if we want to avoid calling pytest.warns on Python 3.2.
While I was in there I did a bit of cleanup.