Add development setup instructions to CONTRIBUTING - #562
Merged
pganssle merged 5 commits intoDec 12, 2017
Merged
pganssle merged 5 commits into
pganssle merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
kynan
force-pushed
the
conda-dev-environment
branch
from
12fe01c to
9c4f5e3
Compare
December 6, 2017 22:16
pganssle
reviewed
Dec 6, 2017
Comment thread
CONTRIBUTING.md
Outdated
| by a PGP key that has, at the very least, been signed by the key which made the | ||
| previous release. A table of release signing keys can be found below: | ||
|
|
||
| Releases | Signing key fingerprint |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The release key stays in the README, but don't worry about doing that, I'll just rearrange it before merging.
Sorry, something went wrong.
pganssle
reviewed
Dec 6, 2017
Comment thread
CONTRIBUTING.md
Outdated
|
|
||
| Run the following commands to create a [conda environment](https://conda.io) with all dependencies installed: | ||
|
|
||
| conda create -n dateutil python=3.6 # Create a conda environment using Python 3.6 |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Why enforce python 3.6? As long as you're using a supported version I think it's fine
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@kynan I made some tweaks to your PR. Let me know what you think - if you agree I'll merge. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@kynan I'll merge this today or tomorrow if you don't object. |
Sorry, something went wrong.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also move building & releasing and testing sections from README to CONTRIBUTING