change the order of cache and byeaster in rrule docstring - #695
Merged
pganssle merged 2 commits intoApr 22, 2018
Merged
pganssle merged 2 commits into
pganssle merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@rmahajan14 You need to add yourself to the AUTHORS.md file and add a changelog.d/695.doc.rst file please. See CONTRIBUTING.md |
Sorry, something went wrong.
pganssle
reviewed
Apr 22, 2018
Comment thread
AUTHORS.md
Outdated
| @@ -1,4 +1,4 @@ | |||
| This is a (possibly incomplete) list of all the contributors to python-dateutil, | |||
| This is a (possibly incomplete) list of all the contributors to python-dateutil, | |||
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
There are a bunch of weird unprintable characters at the beginning of this line. Is this something your editor is doing?
with open('AUTHORS.md', 'rb') as f:
print(f.read(60))
# Result:
# b'\xef\xbb\xbfThis is a (possibly incomplete) list of all the contribut'Since the sequence is 0xEFBBBF, I'm guessing that it's a Windows Byte Order Mark indicating UTF-8. I recommend that you fix your editor so that it doesn't do this anymore.
Sorry, something went wrong.
pganssle
force-pushed
the
rmahajan_rrule_docs
branch
from
0350492 to
2385720
Compare
April 22, 2018 00:14
The documentation had cache and byeaster out of order from their appearance in the function's parameter list. - Added changelog for documentation change
pganssle
force-pushed
the
rmahajan_rrule_docs
branch
from
2385720 to
8b91ed0
Compare
April 22, 2018 00:20
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed order in the rrule docstring to match with order of the keywords.
Closes #686