REF: collect parser methods by function - #882
pganssle merged 3 commits into
Conversation
Sorry, something went wrong.
|
failed build is pypy, looks unrelated |
Sorry, something went wrong.
pganssle
left a comment
There was a problem hiding this comment.
Yeah I think this is a nicer arrangement for the code.
Can you add a misc item to the changelog?
Sorry, something went wrong.
Done. Is there a better word than "Fixed" in this context? |
Sorry, something went wrong.
|
@jbrockmendel I often go with "Patch by ..." when contributing to CPython, but no need to worry. For the moment, these MISC things don't actually generate entries directly in the changelog (though I'm thinking maybe that should change). |
Sorry, something went wrong.
This is a minor refactoring to improve the code organization.
This is merged in the branch for PR dateutil#882 because PR dateutil#735 was accidentally merged without a changelog.
The methods within parser are a bit of a jumble. This separates out two sections for methods that a) act on individual tokens and b) are for creating the datetime output after the string is fully parsed.
No hurry on this if it would cause rebasing conflicts elsewhere.
Methods are unchanged, with the exception of a long line in a comment in to_decimal that is wrapped.