Fix custom repr for ParserError - #993
Merged
pganssle merged 1 commit intoJan 2, 2020
Merged
pganssle merged 1 commit into
pganssle merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thanks for the review @jbrockmendel! |
Sorry, something went wrong.
pganssle
force-pushed
the
parsererror_repr
branch
from
2a36bd6 to
8efe253
Compare
January 2, 2020 19:08
This was originally dead code, because an indentation error had `__repr__` defined after the `return` statement in `__str__`. The definition of the `__repr__` is also changed to be more in line with the conception of a repr as "what you would have to evalue to get this object". Even though this is not guaranteed behavior, this commit also adds a regression test to avoid simple errors like this in the future.
pganssle
force-pushed
the
parsererror_repr
branch
from
8efe253 to
ea7f441
Compare
January 2, 2020 19:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This was originally dead code, because an indentation error had __repr__ defined after the return statement in __str__. The definition of the __repr__ is also changed to be more in line with the conception of a repr as "what you would have to evalue to get this object".
Even though this is not guaranteed behavior, this commit also adds a regression test to avoid simple errors like this in the future.
Closes #991
Pull Request Checklist