FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Custom output formatting by chagris · Pull Request #645 · debug-js/debug · GitHub

/ debug Public

Custom output formatting - #645

Open
chagris wants to merge 8 commits into
debug-js:masterfrom
chagris:format
ConversationCommits (8)ChecksFiles changed
Open

Custom output formatting#645
chagris wants to merge 8 commits into
debug-js:masterfrom
chagris:format

Conversation

chagris commented Dec 13, 2018 •
edited by Qix-
Loading

Copy link
Copy Markdown

Closes #582.

This pull request is an attempt at implementing #582. As stated by my comment there, this code isn't yet complete and actually ready to be merged, and is waiting for edits and feebacks!

coveralls commented Dec 13, 2018 •
edited
Loading

Copy link
Copy Markdown

Coverage increased (+0.4%) to 87.179% when pulling 8fa6444 on chagris:format into 5fadf45 on visionmedia:master.

Qix- added feature This proposes or provides a feature or enhancement change-major This proposes or provides a change that requires a major release labels Dec 13, 2018
Qix- self-requested a review December 13, 2018 15:18

chagris commented Dec 14, 2018

Copy link
Copy Markdown
Author

I added the "metaformatters" flag prefixes %J (JSON.stringify()), %c and %C (color and color + bold (node)) as I proposed here #582 (comment), however I'm not 100% on it (they could just as well stay special-case-flags), so it should be easy to revert

Also, I'm not sure what to do about node's formatters %o / %O coloring (based on DEBUG_COLORS and isatty()), and passing other inspectOpts

Qix- changed the title Custom output formatting implementation proposal (#582) Custom output formatting Dec 19, 2018

Qix- commented Dec 19, 2018

Copy link
Copy Markdown
Member

Hey @chagris - sorry I haven't had time to review this or give much input. However I appreciate the work being done.

Admittedly it'll be a little longer before I'll be able to get to this; however, I've done two things here:

  1. I revised this PR's title a bit to be less 'prototype'-ey
  2. I added the magic keywords Closes #xxx. which Github will handle upon merging this PR.

Qix- added this to the 5.x milestone Dec 19, 2018
Qix- mentioned this pull request Dec 19, 2018
Open
11 tasks
Qix- mentioned this pull request Jan 20, 2019
Closed

RabiaSaid commented Jun 21, 2022

Copy link
Copy Markdown

2.6.8

RabiaSaid commented Jun 21, 2022

Copy link
Copy Markdown

4.3.4

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Qix- Awaiting requested review from Qix-

Assignees

No one assigned

Labels

change-major This proposes or provides a change that requires a major release feature This proposes or provides a feature or enhancement

Milestone

5.x

Development

Successfully merging this pull request may close these issues.

Customizing output format

4 participants

Back | FazBrowse Home | New Git URL