fix(vmm): use the real FICLONE ioctl number - #322
Merged
WaylandYang merged 4 commits intoSep 14, 2026
Merged
WaylandYang merged 4 commits into
WaylandYang merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chain::reflink_copy passed 0x40209409 as FICLONE. The real number is _IOW(0x94, 9, int) = 0x40049409. The kernel matches the full ioctl number, including the size field, so it answered ENOTTY. The fallback treats ENOTTY as "this filesystem has no reflink", so every call silently fell back to a full streamed copy: chain-assembly base memory, and the bake's rootfs baseline clone. That happened even on btrfs, XFS, and ZFS 2.2+.
Found by @jrimmer while measuring #321 (described in a comment there, but the change wasn't in that branch), so it lands on its own here.
Verification
On Ubuntu 22.04 / kernel 5.15, using an XFS loopback made with reflink=1 and a 200 MiB random source file:
A unit test pins the constant to its _IOW derivation.
🤖 Generated with Claude Code