FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: release using PEP 517 by m1so · Pull Request #6 · deepnote/python-lsp-server · GitHub

/ python-lsp-server Public
forked from python-lsp/python-lsp-server

fix: release using PEP 517 - #6

Merged
m1so merged 1 commit into
developfrom
mb/fix-release
Oct 29, 2025
ConversationCommits (1)ChecksFiles changed
Merged

fix: release using PEP 517#6
m1so merged 1 commit into
developfrom
mb/fix-release

Conversation

m1so commented Oct 29, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown

Summary by CodeRabbit

  • Chores
    • Updated build and packaging infrastructure to use modern Python build standards.

Note: This release contains internal build process improvements with no impact to end-user functionality.

m1so requested a review from mfranczel October 29, 2025 16:27

coderabbitai Bot commented Oct 29, 2025 •
edited
Loading

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

The release workflow in .github/workflows/release.yml has been updated to shift from setuptools-based packaging to PEP 517/518 build standards. The caching key now targets pyproject.toml instead of setup.py. Build dependencies have been consolidated—replacing setuptools and wheel with the build package—and the explicit wheel and source distribution commands are now unified into a single python -m build invocation.

Possibly related PRs

  • ci: Publish to pypi #2: Modifies the same release workflow with related adjustments to packaging and environment variables.

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "fix: release using PEP 517" directly describes the main change in the changeset. The release workflow is being updated to transition from setuptools-based packaging to PEP 517/518 build tooling, which is exactly what the title conveys. The title is specific, concise, and avoids vague language—it clearly indicates the primary purpose of the changes.
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 08554e6 and c12c4a4.

📒 Files selected for processing (1)
  • .github/workflows/release.yml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: Win Py3.9
  • GitHub Check: Win Py3.11
  • GitHub Check: Win Py3.10
  • GitHub Check: Mac Py3.9
  • GitHub Check: Mac Py3.10
  • GitHub Check: Linux Py3.11
  • GitHub Check: Linux Py3.10
  • GitHub Check: Linux Py3.9
  • GitHub Check: Mac Py3.11
🔇 Additional comments (3)
.github/workflows/release.yml (3)

40-40: Build dependencies correctly consolidated to build package.

Replacing explicit setuptools wheel with build is the proper PEP 517 approach.

43-43: Project properly configured for PEP 517 builds.

Verified: pyproject.toml contains [build-system] with build-backend = "setuptools.build_meta" and required dependencies. The python -m build command will correctly orchestrate the build per PEP 517.

29-29: Cache key change is valid.

pyproject.toml exists and declares build-backend = "setuptools.build_meta", confirming PEP 517 setup.

Comment @coderabbitai help to get the list of available commands and usage tips.

m1so merged commit 88e4ee1 into develop Oct 29, 2025
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mfranczel mfranczel approved these changes
coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL