Fix import deepspeed crash on PyTorch v2.3 + Python 3.12 - #7875
Merged
tohtana merged 5 commits intoMar 2, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
Copy link
Copy Markdown
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e1c74fb604
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
Comment thread
deepspeed/utils/torch.py
tjruwase
approved these changes
Mar 1, 2026
nathon-lee
pushed a commit
to nathon-lee/DeepSpeed_woo
that referenced
this pull request
Mar 7, 2026
…#7875) `import deepspeed` raises `RuntimeError: Dynamo is not supported on Python 3.12+` on PyTorch 2.3 + Python 3.12. The `jit_script_compat` decorator (introduced in deepspeedai#7835) calls `torch.compile()` unconditionally on PyTorch >= 2.0, but Dynamo support for Python 3.12 was only added in PyTorch 2.4. Multiple eager import chains trigger this decorator at import time, crashing before user code runs. This PR adds a version gate to skip torch.compile on known-unsupported combinations, plus a double fallback (torch.compile → torch.jit.script → identity function) so the decorator won't crash. --------- Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com> Co-authored-by: Olatunji Ruwase <tjruwase@gmail.com> Signed-off-by: nathon-lee <leejianwoo@gmail.com>
nathon-lee
pushed a commit
to nathon-lee/DeepSpeed_woo
that referenced
this pull request
Mar 28, 2026
…#7875) `import deepspeed` raises `RuntimeError: Dynamo is not supported on Python 3.12+` on PyTorch 2.3 + Python 3.12. The `jit_script_compat` decorator (introduced in deepspeedai#7835) calls `torch.compile()` unconditionally on PyTorch >= 2.0, but Dynamo support for Python 3.12 was only added in PyTorch 2.4. Multiple eager import chains trigger this decorator at import time, crashing before user code runs. This PR adds a version gate to skip torch.compile on known-unsupported combinations, plus a double fallback (torch.compile → torch.jit.script → identity function) so the decorator won't crash. --------- Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com> Co-authored-by: Olatunji Ruwase <tjruwase@gmail.com> Signed-off-by: nathon-lee <leejianwoo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import deepspeed raises RuntimeError: Dynamo is not supported on Python 3.12+ on PyTorch 2.3 + Python 3.12.
The jit_script_compat decorator (introduced in #7835) calls torch.compile() unconditionally on PyTorch >= 2.0, but Dynamo support for Python 3.12 was only added in PyTorch 2.4.
Multiple eager import chains trigger this decorator at import time, crashing before user code runs.
This PR adds a version gate to skip torch.compile on known-unsupported combinations, plus a double fallback (torch.compile → torch.jit.script → identity function) so the decorator won't crash.