double reduction user-friendly error - #7895
Merged
sfc-gh-truwase merged 1 commit intoMar 10, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
before: ``` AssertionError: The parameter 0 has already been reduced. ... ``` after: ``` AssertionError: The parameter model.embed_tokens.weight has already been reduced. ```
sfc-gh-truwase
approved these changes
Mar 10, 2026
nathon-lee
pushed a commit
to nathon-lee/DeepSpeed_woo
that referenced
this pull request
Mar 28, 2026
Currently a numerical order of the param tells nothing to the user of what param is the problem. This PR fixes that. before: ``` AssertionError: The parameter 0 has already been reduced. ... ``` after: ``` AssertionError: The parameter model.embed_tokens.weight has already been reduced. ``` Signed-off-by: nathon-lee <leejianwoo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a numerical order of the param tells nothing to the user of what param is the problem. This PR fixes that.
before:
after: