Fix backward compatibility of torch.amp.custom_fwd for PyTorch < 2.4 - #7920
Merged
tohtana merged 4 commits intoMar 25, 2026
Merged
Fix backward compatibility of torch.amp.custom_fwd for PyTorch < 2.4#7920tohtana merged 4 commits into
tohtana merged 4 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
Copy link
Copy Markdown
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52f3d04267
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
Comment thread
deepspeed/runtime/zero/linear.py
Outdated
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
PKUWZP
approved these changes
Mar 25, 2026
PKUWZP
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Thanks for submitting the PR, LGTM.
Sorry, something went wrong.
tohtana
enabled auto-merge (squash)
March 25, 2026 21:21
nathon-lee
pushed a commit
to nathon-lee/DeepSpeed_woo
that referenced
this pull request
Mar 27, 2026
…eepspeedai#7920) `torch.amp.custom_fwd` was introduced in PyTorch 2.4, so installing DeepSpeed from source with an older PyTorch fails because `setup.py` triggers an import of the function. This PR adds a fallback to `torch.cuda.amp.custom_fwd` for PyTorch < 2.4. --------- Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
nathon-lee
pushed a commit
to nathon-lee/DeepSpeed_woo
that referenced
this pull request
Mar 28, 2026
…eepspeedai#7920) `torch.amp.custom_fwd` was introduced in PyTorch 2.4, so installing DeepSpeed from source with an older PyTorch fails because `setup.py` triggers an import of the function. This PR adds a fallback to `torch.cuda.amp.custom_fwd` for PyTorch < 2.4. --------- Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com> Signed-off-by: nathon-lee <leejianwoo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
torch.amp.custom_fwd was introduced in PyTorch 2.4, so installing DeepSpeed from source with an older PyTorch fails because setup.py triggers an import of the function.
This PR adds a fallback to torch.cuda.amp.custom_fwd for PyTorch < 2.4.