Update topkgating probability-mask test expectation - #8007
Merged
tohtana merged 1 commit intoMay 13, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
delock
approved these changes
May 13, 2026
nathon-lee
pushed a commit
to nathon-lee/DeepSpeed_woo
that referenced
this pull request
Jul 1, 2026
After deepspeedai#7986, `tests/unit/moe/test_moe.py::TestTopkGate::test` started failing because the expected mask changed. This was caught by the full CI run ([log](https://github.com/deepspeedai/DeepSpeed/actions/runs/25724245746)). This PR updates `TestTopkGate`'s `drop_policy='probs'` expected mask for the `logits2` case to match the probability-based capacity selection introduced by deepspeedai#7986. Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com> Signed-off-by: nathon-lee <leejianwoo@gmail.com>
nathon-lee
pushed a commit
to nathon-lee/DeepSpeed_woo
that referenced
this pull request
Jul 1, 2026
After deepspeedai#7986, `tests/unit/moe/test_moe.py::TestTopkGate::test` started failing because the expected mask changed. This was caught by the full CI run ([log](https://github.com/deepspeedai/DeepSpeed/actions/runs/25724245746)). This PR updates `TestTopkGate`'s `drop_policy='probs'` expected mask for the `logits2` case to match the probability-based capacity selection introduced by deepspeedai#7986. Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #7986, tests/unit/moe/test_moe.py::TestTopkGate::test started failing because the expected mask changed. This was caught by the full CI run (log).
This PR updates TestTopkGate's drop_policy='probs' expected mask for the logits2 case to match the probability-based capacity selection introduced by #7986.