Add compile.offload_activation_pin_memory for DeepCompile activation offload - #8258
Merged
pengdurice merged 1 commit intoAug 16, 2026
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
…offload Expose a default-true knob so DeepCompile host offload buffers can use pageable memory under tight memlock limits, without changing the default pinned behavior. Signed-off-by: Olatunji Ruwase <tunji.ruwase@snowflake.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Copy link
Copy Markdown
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Sorry, something went wrong.
PKUWZP
self-requested a review
August 16, 2026 03:26
PKUWZP
approved these changes
Aug 16, 2026
Copy link
Copy Markdown
Contributor
|
@sfc-gh-truwase , thank you for the PR! #8255 is for enabling activation offload in the deep compile schedules. Feel free to review when it is ready;-) |
Sorry, something went wrong.
pengdurice
approved these changes
Aug 16, 2026
sfc-gh-truwase
added a commit
that referenced
this pull request
Aug 20, 2026
Honor DS_PIN_MEMORY_BACKEND for the common contiguous checkpoint-input path. Strided views keep ATen empty_strided pin because native pin cannot preserve arbitrary strides. Document pin on/off vs backend; DeepCompile compile.offload_activation_pin_memory already landed in #8258. Signed-off-by: Olatunji Ruwase <tunji.ruwase@snowflake.com> Co-authored-by: Cursor <cursoragent@cursor.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan