This repository was archived by the owner on May 6, 2020. It is now read-only.
fix(config): when rolling a new config copy from the latest release instead of latest config for the app - #805
Merged
helgi merged 1 commit intoJun 9, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
By analyzing the blame information on this pull request, we identified @smothiki to be a potential reviewer |
Sorry, something went wrong.
Copy link
Copy Markdown
Current coverage is 85.86%@@ master #805 diff @@
==========================================
Files 30 30
Lines 2692 2696 +4
Methods 0 0
Messages 0 0
Branches 439 439
==========================================
+ Hits 2308 2315 +7
+ Misses 259 257 -2
+ Partials 125 124 -1
|
Sorry, something went wrong.
…nstead of latest config for the app This helps mitigate deis#798 for day to day use (quick fix) as the previous config is no longer pulled from the top of the application config stack and instead pulls the latest release config. Doing that will prevent the logic from re-using a potentially broken Config object. When a Release object is deleted an Config object can be orphaned but still available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This helps mitigate #798 for day to day use (quick fix) as the previous config is no longer pulled from the top of the application config stack and instead pulls the latest release config.
Doing that will prevent the logic from re-using a potentially broken Config object. When a Release object is deleted an Config object can be orphaned but still available.
Issue(s) that this PR Closes
refs #798
Testing Instructions
Ideally this change should be tested as part of #792 as that PR has the failure condition required (and the commit from this PR) but I decided that it was better to get them merged individually.