FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix pyMethodDef layout by sigmaSd · Pull Request #65 · denosaurs/deno_python · GitHub

fix pyMethodDef layout - #65

Merged
DjDeveloperr merged 2 commits into
denosaurs:mainfrom
sigmaSd:pad
Jul 15, 2024
Merged

fix pyMethodDef layout#65
DjDeveloperr merged 2 commits into
denosaurs:mainfrom
sigmaSd:pad

Conversation

sigmaSd commented Jul 14, 2024

Copy link
Copy Markdown
Contributor

fix #64
from AapoAlas

Yeah, the last pointer is not correctly aligned. Pointers should be 8 byte aligned (regardless of architecture), but it's at byte index 20: 20/8 does not an integer make.
So 24 is the correct place for it

DjDeveloperr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks!

CI seems to be broken due to something else, I'll look into that later.

DjDeveloperr merged commit 43e4957 into denosaurs:main Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

segfault when overriding a class method in jupyter kernel

2 participants


Back | FazBrowse Home | New Git URL