chore: Bump (most) deps - #1081
rschristian wants to merge 7 commits into
Conversation
Sorry, something went wrong.
Co-authored-by: Jason Miller <developit@users.noreply.github.com>
🦋 Changeset detectedLatest commit: de49a51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sorry, something went wrong.
|
Size Change: 0 B Total Size: 65.9 kB ℹ️ View Unchanged
|
Sorry, something went wrong.
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "moduleResolution": "node", | |||
There was a problem hiding this comment.
tslib otherwise can't be found, oddly. This should be the default but maybe rtp2 is doing something odd.
Sorry, something went wrong.
|
This is IMO very important to merge. I need to manualy override "rollup-plugin-typescript2" to latest (0.36.0) everywhere I use microbundle, else it can't compile typescript because it can't find the types: (rpt2 plugin) Error: ...ts(x,x): semantic error TS2307: Cannot find module '...' or its corresponding type declarations. There are types at '....d.ts', but this result could not be resolved under your current 'moduleResolution' setting. Consider updating to 'node16', 'nodenext', or 'bundler'. I had the solution found a year or so ago, but forgot about it and did get cought by it again and wasted a few hours to find out how to solve it. Workaround: Add this to your package.json "overrides": {
"rollup-plugin-typescript2": "^0.36.0"
}
If you use npm workspaces make sure it is overwritten and not existing anymore in node_modules/microbundle/node_modules. |
Sorry, something went wrong.
|
@developit If you have a few minutes, would appreciate a peek at this and potentially #1082 & #1083 -- we're starting to hit dep rot |
Sorry, something went wrong.
| @@ -2320,26 +2319,26 @@ modern-generators | |||
|
|
|||
|
|
|||
| Build \\"modern-generators\\" to dist: | |||
| 248 B: modern-generators.js.gz | |||
| 201 B: modern-generators.js.br | |||
| 2.57 kB: modern-generators.js.gz | |||
There was a problem hiding this comment.
Are we ok with this massive increase?
Sorry, something went wrong.
There was a problem hiding this comment.
Hey, long time no see! Hope all is well & good w/ you.
Mentioned this above in a resolved comment:
Oh nice, 7.18.0 ended up inlining regenerator as a normal helper, dropping the global: babel/babel#14538
This is a sizable increase but IMO it's completely reasonable.
I still think this is reasonable, but admittedly, I was very much not a fan of Babel's previous behavior.
Do you disagree with this? I suppose we could work around it and revert to previous behavior if we really needed to.
Sorry, something went wrong.
There was a problem hiding this comment.
All good, how about you?
So if I'm understanding it correctly, the previous size was somewhat misleading because the runtime was needed?
But now that it's inlined it will be duplicated for each library built this way
Maybe @developit could give his opinion
Sorry, something went wrong.
There was a problem hiding this comment.
Not bad, thanks!
You're right, yep. regeneratorRuntime was a unique case in that instead of being inlined, as every other Babel helper is, it was consumed as a global with the expectation that the user makes it available. This tripped up a great many users over the years (Preact org issues, for reference, and you can find many hundred similar issues elsewhere) as it was a bit odd and had questionable DX.
Indeed though, like all Babel helpers this can end up duplicated and it's particularly bad if it is -- even gzip isn't going to save you there.
That being said, I'm not sure there's a whole heck of a lot that we can do, or nothing comes to mind at least. If a user is bundling their deps with Microbundle, and one of those deps has this helper inlined, there's still duplication whether we stick with the old global or duplicate it. In a perfect world every module would be distributing modern bundles with minimal transpiling/helpers, but... :/ Heck, even our "modern" is still ES2017, could probably do with a bump to 2019-2020?
Sorry, something went wrong.
There was a problem hiding this comment.
I am wondering why the modern output has regenerator in it at all, since ES2017 supports generators.
Maybe we need to configure Babel "assumptions"?
Sorry, something went wrong.
There was a problem hiding this comment.
This is perhaps a poorly named test case: modern-generators is the package name, which forms the output file name. modern-generators.modern.js is the modern output, and it's unchanged.
Caught me off guard once or twice too, could rename it to just generators I suppose.
Sorry, something went wrong.
Reviewers
At least 1 approving review is required to merge this pull request.
Supersedes #969