fix: Resolve entries against cwd - #1091
Open
rschristian wants to merge 3 commits into
Open
rschristian wants to merge 3 commits into
rschristian wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
⚠️ No Changeset foundLatest commit: 0485a4c Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Size Change: 0 B Total Size: 65.9 kB ℹ️ View Unchanged
|
Sorry, something went wrong.
rschristian
marked this pull request as draft
February 17, 2025 07:54
rschristian
force-pushed
the
fix/glob-entry
branch
2 times, most recently
from
c4ef5dc to
4167d53
Compare
October 24, 2025 02:51
rschristian
force-pushed
the
fix/glob-entry
branch
from
4167d53 to
0485a4c
Compare
October 24, 2025 02:53
rschristian
commented
Oct 24, 2025
Comment thread
tools/build-fixture.js
Comment on lines
+59
to
+62
| // Now that dirs have been cleared, reset the fixturePath back to the parent dir | ||
| if (fixtureDir.endsWith('-with-cwd')) { | ||
| fixturePath = resolve(FIXTURES_DIR, fixtureDir); | ||
| } |
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
This was super broken & went unnoticed for a long time.
Basically we make the assumption that a test fixture foo-with-cwd is testing --cwd ./foo, and to make sure we were clearing out past runs, set the fixture path to fixtures/foo-with-cwd/foo so that rimraf would clear out all test cases the same way. However, we never set this path back!
When it came time to get the build script & execute it, the CWD was /foo-with-cwd/foo... none of these nested directories actually had a build script defined, as it was meant to come from the parent, and so all of the -with-cwd tests were just running plain microbundle. The build script we provided for our tests was entirely ignored as the test was always ran from the incorrect working dir.
Easy fix though, we just have to reset it.
Sorry, something went wrong.
rschristian
marked this pull request as ready for review
October 24, 2025 03:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preactjs/preact#4677
tiny-glob resolves against opts.cwd or ., and because we don't pass cwd into tiny-glob, this can result in incorrect file paths when used with Microbundle's --cwd flag.
Edit: Meant to open this as a draft, needs tests & ideally errors thrown for missing inputs Edit2: Unfortunately we don't throw on missing inputs anywhere else so that'd be inconsistent.