Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Do you think it is better to add support cancelToken API similar to axios cancel token instead of passing abortController signal directly?

Example from axios

const CancelToken = axios.CancelToken;
const source = CancelToken.source();

axios.get('/user/12345', {
  cancelToken: source.token
}).catch(function (thrown) {
  if (axios.isCancel(thrown)) {
    console.log('Request canceled', thrown.message);
  } else {
    // handle error
  }
});

axios.post('/user/12345', {
  name: 'new name'
}, {
  cancelToken: source.token
})

// cancel the request (the message parameter is optional)
source.cancel('Operation canceled by the user.');

We can create a CancelToken function that wrap around the AbortController and return signal as a cancel token, what do you think?

@developit @n3tr To support the axios API I think we'll have to implement the CancelToken like this

function CancelToken(fn) {
	const ac = new AbortController();
	fn && fn(() => ac.abort());
	return ac.signal;
}
CancelToken.source = () => {
	const ac = new AbortController();
	return {
		token: ac.signal,
		cancel: () => ac.abort()
	};
};

By implementing CancelToken this we can support both the use-cases of cancel token
Use Case 1

const CancelToken = axios.CancelToken;
let cancel;

axios.get('/user/12345', {
  cancelToken: new CancelToken(function executor(c) {
    // An executor function receives a cancel function as a parameter
    cancel = c;
  })
});

// cancel the request
cancel();

Use Case 2

const CancelToken = axios.CancelToken;
const source = CancelToken.source();

axios.get('/user/12345', {
  cancelToken: source.token
}).catch(function (thrown) {
  if (axios.isCancel(thrown)) {
    console.log('Request canceled', thrown.message);
  } else {
    // handle error
  }
});

axios.post('/user/12345', {
  name: 'new name'
}, {
  cancelToken: source.token
})

// cancel the request (the message parameter is optional)
source.cancel('Operation canceled by the user.');

I have tested this locally So if you want I can push this implementation of CancelToken

Looks good. I will have to golf it down a lot, but it's nice to see what the API is supposed to be.

@developit I pushed the changes, thought a lot about golfing it down, but no breakthrough...

Merged master and fixed conflicts

Thanks for putting in the effort to keep this moving forward @melwyn95, I'll take another look!

Some great work here - will this be merged into main branch soon?

@developit Any idea when this will be merged? Or is there something we can help with in order to get this ready for merge?

Hi @developit @melwyn95

Any plans to merge this?

@developit @melwyn95 bumping this

@developit @melwyn95 bumping this