FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Isomorphic-unfetch typescript definition error · Issue #87 · developit/unfetch · GitHub

  1. developit
  2. unfetch

Repository navigation

Isomorphic-unfetch typescript definition error #87

Closed
Closed
Isomorphic-unfetch typescript definition error#87

Description

deptno
opened on Aug 26, 2018

Hi.

https://github.com/developit/unfetch/blob/master/packages/isomorphic-unfetch/index.js#L1

code uses module.exports, but definition is using export default, I think it should be export = in https://github.com/developit/unfetch/blob/master/packages/isomorphic-unfetch/index.d.ts#L17

and use with `import * as fetch from 'isomorphic-unfetch'

Related issue

Activity

  1. developit commented on Sep 13, 2018

    developit
    on Sep 13, 2018
    Owner

    Definitely - would you be up for PR'ing that change?

  2. deptno
    added a commit that references this issue on Sep 14, 2018

    fix developit#87 change isomorphic-fetch ts definition: export defaul…

    0d90045

  3. deptno commented on Sep 14, 2018

    deptno
    on Sep 14, 2018
    ContributorAuthor

    #89

  4. developit
    closed this as completedin 0d90045on Sep 17, 2018
  5. developit
    added a commit that references this issue on Sep 17, 2018

    fix #87 change isomorphic-fetch ts definition: export default to expo…

    ce45d59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      Back | FazBrowse Home | New Git URL