window -> self - #109
Merged
developit merged 1 commit intoSep 29, 2020
Merged
window -> self#109developit merged 1 commit into
developit merged 1 commit into
Conversation
Copy link
Copy Markdown
Owner
Sorry, something went wrong.
Replace `window` with `self` to allow use in Web Workers.
Copy link
Copy Markdown
|
Any chance to merge this? We need isomorphic-unfetch on a web-worker. Thanks! |
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
Author
|
This fix was released in 4.2.0. Sorry for the super long wait! |
Sorry, something went wrong.
Copy link
Copy Markdown
|
For the record (and for googlers), this change breaks this library in a React Native environment with error "Can't find variable: self". Quick fix is to roll back to isomorphic-unfetch 3.0.0. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace window with self to allow use in Web Workers.
The main library was already doing this, just not isomorphic-unfetch.
Fixes #104.