Capture JSON parsing errors in Promise - #112
Merged
developit merged 2 commits intoFeb 19, 2020
Merged
developit merged 2 commits into
developit merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
iiroj
approved these changes
Jul 10, 2019
Copy link
Copy Markdown
There was a problem hiding this comment.
We were also hit by this problem, and the change here certainly fixes it:
// Promise.resolve(JSON.parse(undefined)).then(() => console.log('success')).catch(() => console.log('fail'))
SyntaxError: JSON.parse: unexpected character at line 1 column 1 of the JSON data// Promise.resolve(undefined).then(JSON.parse).then(() => console.log('success')).catch(() => console.log('fail'))
fail
Sorry, something went wrong.
pladaria
approved these changes
Nov 25, 2019
pladaria
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
developit
approved these changes
Feb 18, 2020
developit
left a comment
Copy link
Copy Markdown
Owner
There was a problem hiding this comment.
So sorry for sleeping on this PR!
Sorry, something went wrong.
developit
added a commit
to kalisjoshua/unfetch
that referenced
this pull request
Feb 19, 2020
Copy link
Copy Markdown
Owner
|
Released in 4.2.0. Sorry for the super long wait! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently invalid JSON in the response throws immediately instead of asynchronously.