FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Proper TS types by Andarist · Pull Request #117 · developit/unfetch · GitHub

  1. developit
  2. unfetch

Repository navigation

Proper TS types #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
developit merged 4 commits into from
Sep 29, 2020
Conversation 8 Commits 4 Checks 0 Files changed
Merged

Proper TS types #117

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71f0643
Proper TS types
Andarist Jun 28, 2019
cc56c3c
Merge branch 'master' into better-types
developit Feb 18, 2020
b783a1a
Merge branch 'master' into better-types
developit Feb 19, 2020
9f2ca62
Merge branch 'master' into better-types
developit Sep 29, 2020
File filter

Filter by extension

Filter by extension .ts  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
29 changes: 28 additions & 1 deletion src/index.d.ts
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,33 @@ declare namespace unfetch {
export type IsomorphicRequest = Request | NodeRequest
}

declare const unfetch: typeof fetch;
type UnfetchResponse = {

1999 Feb 25, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Wouldn't it be better if we export this type so that TS developers could use it in their code?
ok: boolean,
statusText: string,
status: number,
url: string,
text: () => Promise<string>,
json: () => Promise<any>,
blob: () => Promise<Blob>,
clone: () => UnfetchResponse,
headers: {
keys: () => string[],
entries: () => Array<[string, string]>,
get: (key: string) => string | undefined,
has: (key: string) => boolean,
}
}

type Unfetch = (

1999 Feb 25, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Same
url: string,
options?: {
method?: string,
headers?: Record<string, string>,
credentials?: 'include' | 'omit',
body?: Parameters<XMLHttpRequest["send"]>[0]
}
) => Promise<UnfetchResponse>

declare const unfetch: Unfetch;

export default unfetch;
Back | FazBrowse Home | New Git URL