FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update node-fetch version. Refs #143 by matheo · Pull Request #154 · developit/unfetch · GitHub

  1. developit
  2. unfetch

Repository navigation

Update node-fetch version. Refs #143 - #154

Closed
matheo wants to merge 2 commits into
developit:mainfrom
matheo:master
ConversationCommits (2)ChecksFiles changed
Closed

Update node-fetch version. Refs #143#154
matheo wants to merge 2 commits into
developit:mainfrom
matheo:master

Conversation

matheo commented Jan 2, 2022

Copy link
Copy Markdown

No description provided.

robreinhard commented Jan 25, 2022

Copy link
Copy Markdown

This needs to be high priority @developit, there's a vulnerability in node-fetch https://nvd.nist.gov/vuln/detail/CVE-2022-0235

robreinhard mentioned this pull request Jan 25, 2022
Closed
lounsbrough reviewed Jan 28, 2022
View reviewed changes
Comment thread packages/isomorphic-unfetch/package.json
"types": "index.d.ts",
"dependencies": {
"node-fetch": "^2.6.1",
"node-fetch": "^3.1.0",

lounsbrough Jan 28, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Doesn't this need to be 3.1.1? https://github.com/node-fetch/node-fetch/releases/tag/v3.1.1

robreinhard Jan 28, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@lounsbrough I agree.

matheo Jan 28, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

^ resolves to any following minor/patch version so we just need a refresh of the lock file

lounsbrough commented Jan 28, 2022

Copy link
Copy Markdown

I assume there might be breaking changes here, specifically the module has moved to ESM only.

RishikeshDarandale mentioned this pull request Feb 3, 2022
Merged

developit commented Dec 31, 2022

Copy link
Copy Markdown
Owner

fixed in #156

developit closed this Dec 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
lounsbrough lounsbrough left review comments
robreinhard robreinhard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL