Add full TypeScript definitions and export them, add basic TS tests. - #159
Merged
developit merged 3 commits intoDec 31, 2022
Merged
developit merged 3 commits into
developit merged 3 commits into
Conversation
Copy link
Copy Markdown
Owner
Sorry, something went wrong.
Copy link
Copy Markdown
|
Size Change: 0 B Total Size: 1.06 kB ℹ️ View Unchanged
|
Sorry, something went wrong.
Copy link
Copy Markdown
|
Hi there, I don't know if this something have to do with this fix, but since I use the latest version I get eslint errors. I'm using fetch like this this in my projects: import fetch from 'isomorphic-unfetch' Since the update I get: ESLint: No default export found in imported module "isomorphic-unfetch".(import/default) |
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
Author
|
hey @kolorfilm - thanks for the ping, I had forgotten to remove the "files" field from isomorphic-unfetch and the publish was missing index.mjs and browser.mjs from the package. I just published isomorphic-unfetch@4.0.2 with the fix. (as validated on unpkg) |
Sorry, something went wrong.
kodiakhq Bot
referenced
this pull request
in X-oss-byte/Nextjs
Oct 16, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [unfetch](https://togithub.com/developit/unfetch) | [`4.2.0` -> `5.0.0`](https://renovatebot.com/diffs/npm/unfetch/4.2.0/5.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>developit/unfetch (unfetch)</summary> ### [`v5.0.0`](https://togithub.com/developit/unfetch/releases/tag/5.0.0) [Compare Source](https://togithub.com/developit/unfetch/compare/4.2.0...5.0.0) #### What's Changed - Add TypeScript definitions and export them [@​developit](https://togithub.com/developit) in [https://github.com/developit/unfetch/pull/159](https://togithub.com/developit/unfetch/pull/159) - Add [Package Exports](https://togithub.com/developit/unfetch/blob/ed9469aab15e2cd8c243995a8ba964599467e413/package.json#L16-L26) to both unfetch and isomorphic-unfetch #### New Contributors - [@​RishikeshDarandale](https://togithub.com/RishikeshDarandale) made their first contribution to isomorphic-unfetch in [https://github.com/developit/unfetch/pull/156](https://togithub.com/developit/unfetch/pull/156) **Full Changelog**: developit/unfetch@4.2.0...5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Nextjs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm hoping this addresses #144. The definitions are exported both as Unfetch-prefixed names, and within an Unfetch namespace (Unfetch.Response). They're almost compatible with the standard Response/Headers/RequestInit types, except where Unfetch's Headers implementation uses an Array instead of an Iterable - the types being incompatible there is actually accurate, it's not currently possible to do response.headers.entries().next() in unfetch.