fix: invalid path for export in package.json (v 5.0.0) by cristianoliveira · Pull Request #164 · developit/unfetch · GitHub

First of all, thanks for this library! We have been using it for quite a long time, and it works like a charm.

Description

It seems that there are invalid values exported in the package.json https://github.com/developit/unfetch/blob/main/package.json#L18

It causes issue while using unfetch as a module, for instance, we use webpack and once upgraded to 5.0.0 it started to break the build with the given (not so clear, to say the least) error:

ERROR in ./src/index.js 1:0-30
Module not found: Error: Can't resolve 'unfetch' in '/Users/user/dev/unfetch-issue-demo/src'
resolve 'unfetch' in '/Users/user/dev/unfetch-issue-demo/src'
  Parsed request is a module
  using description file: /Users/user/dev/unfetch-issue-demo/package.json (relative path: ./src)
    Field 'browser' doesn't contain a valid alias configuration
    resolve as module
      /Users/user/dev/unfetch-issue-demo/src/node_modules doesn't exist or is not a directory
      looking for modules in /Users/user/dev/unfetch-issue-demo/node_modules
        single file module
          using description file: /Users/user/dev/unfetch-issue-demo/package.json (relative path: ./node_modules/unfetch)
            no extension
              Field 'browser' doesn't contain a valid alias configuration
              /Users/user/dev/unfetch-issue-demo/node_modules/unfetch is not a file
            .tsx
              Field 'browser' doesn't contain a valid alias configuration
              /Users/user/dev/unfetch-issue-demo/node_modules/unfetch.tsx doesn't exist
            .ts
              Field 'browser' doesn't contain a valid alias configuration
              /Users/user/dev/unfetch-issue-demo/node_modules/unfetch.ts doesn't exist
            .js
              Field 'browser' doesn't contain a valid alias configuration
              /Users/user/dev/unfetch-issue-demo/node_modules/unfetch.js doesn't exist
            .jsx
              Field 'browser' doesn't contain a valid alias configuration
              /Users/user/dev/unfetch-issue-demo/node_modules/unfetch.jsx doesn't exist
        existing directory /Users/user/dev/unfetch-issue-demo/node_modules/unfetch
...

Demo

Here you can see an example of this issue:
https://github.com/cristianoliveira/unfetch-issue-demo

Solution

After pointing to src/index.mjs it started to compile again and it is working as expected. 😄

Let me know if this is the right solution.

Relates to

#163
#162

For those who use webpack and want a quick fix, while this isn't correctly addressed, you can create an alias and point to the correct file:

In the webpack.config.js include:

  resolve: {
    alias: {
      'unfetch': path.resolve(__dirname, 'node_modules/unfetch/dist/unfetch.mjs'),
    },
  },

Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>

Looks correct to me!

@rschristian @developit pinging in case you have forgotten to approve

Sorry, not a maintainer, my approval does nothing. Just a drive-by suggestion as I ran into this and was seeing if anyone had submitted a fix yet.

For those who use webpack and want a quick fix, while this isn't correctly addressed, you can create an alias and point to the correct file:

In the webpack.config.js include:
  resolve: {
    alias: {
      'unfetch': path.resolve(__dirname, 'node_modules/unfetch/dist/unfetch.mjs'),
    },
  },

Workes fine. Thanks

This is pending a fix to a how unfetch 5 exports its files, e.g. developit/unfetch#164

Can this be merged? I really need this change since in cannot start storybook in my project, Thanks for fixing this! 🥳

@rschristian , Kindly approve & merge it

@rschristian , Kindly approve & merge it

#164 (comment)

@rschristian , Kindly approve & merge it

#164 (comment)

But its showing that your review is pending..

Doesn't matter -- GitHub's UI is a bit weird there for sure, but the approval of non-maintainers does nothing. You'd see a "collaborator" badge (I think) next to my name if I was able to approve and merge.

@developit ?

This would be really nice to have merged since it currently is unusable in vite without a manual override.

For anyone else using vite, adding a resolve alias solved this for now:

defineConfig({
  resolve: {
    alias: {
      unfetch: path.resolve(__dirname, "node_modules/unfetch/dist/unfetch.mjs"),
    }
  }
})

This would be really nice to have merged since it currently is unusable in vite without a manual override.

=> Failed to build the preview
ReferenceError: path is not defined

And if I'm importing

import path from 'path';

I'm still getting
Error: Failed to resolve entry for package "unfetch". The package may have incorrect main/module/exports specified in its package.json.

Without this patch people were experiencing problems when bundling the SDK. See issue ToucanProtocol#95 ToucanProtocol#95 The problem is that `isomorphic-unfetch` 4.0.2 upgraded to `unfetch` 5.0.0 which currently has an issue with their module exports leading to an error when bundling the lib itself or any other lib that depends on `unfetch`. See this PR for more information: developit/unfetch#164 Once this PR is merged we can go back to the latest `isomorphic-unfetch` version.

Without this patch people were experiencing problems when bundling the SDK. See issue ToucanProtocol#95 ToucanProtocol#95 The problem is that `isomorphic-unfetch` 4.0.2 upgraded to `unfetch` 5.0.0 which currently has an issue with their module exports leading to an error when bundling the lib itself or any other lib that depends on `unfetch`. See this PR for more information: developit/unfetch#164 Once the PR above is merged we can go back to the latest `isomorphic-unfetch` version.

Can someone merge this, please?

An issue with `unfetch@5`, depended on by `isomorphic-unfetch@4.0.2`, breaks bundling with tools such as `esbuild` and `webpack`: developit/unfetch#164

Any chance this can get merged and published? Lots of bundler workarounds required right now 😅

@developit is this possible to merge? Not sure on the status on the library, but this one would be a really helpful fix.

fix: invalid path for export in package.json

bd42482

rschristian reviewed Feb 15, 2023

View reviewed changes

Comment thread package.json Outdated

fix: point to dist files

d0ccf20

Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>

cristianoliveira requested a review from rschristian February 15, 2023 16:08

enzoferey mentioned this pull request Feb 16, 2023

fix: resolve unfetch package entrypoint properly enzoferey/network-gas-price#16

Merged

TheLuckyLuc mentioned this pull request Mar 16, 2023

Downgrade isomorphic-unfetch package from 4.0.2 to 4.0.0 HubbleHQ/request#28

Merged

narthur approved these changes Mar 24, 2023

View reviewed changes

NickMcBurney mentioned this pull request May 4, 2023

unfetch@5.0.0 published package might be missing files #162

Open

rschristian mentioned this pull request Aug 1, 2023

Fixed module not found: Can't resolve 'unfetch' #173

Open

martaver mentioned this pull request Aug 3, 2023

[Bug]: use of isomorphic-unfetch breaks storybook-next build storybookjs/storybook#23700

Open

jonathansick added a commit to lsst-sqre/squareone that referenced this pull request Aug 15, 2023

Downgrade unfetch to 4.2.0

51594db

This is pending a fix to a how unfetch 5 exports its files, e.g. developit/unfetch#164

jonathansick added a commit to lsst-sqre/squareone that referenced this pull request Aug 16, 2023

Downgrade unfetch to 4.2.0

a40bbe3

This is pending a fix to a how unfetch 5 exports its files, e.g. developit/unfetch#164

juicy-g mentioned this pull request Sep 9, 2023

Module not found: Can't resolve 'unfetch' alexandermendes/ra-supabase-media-library#1

Open

Skopea approved these changes Sep 9, 2023

View reviewed changes

alinasir85 mentioned this pull request Oct 24, 2023

[Dependency Issue] Isomorphic-unfetch: invalid path for export in package.json ToucanProtocol/toucan-sdk#95

Closed

pheuberger mentioned this pull request Nov 29, 2023

P2: fix: downgrade isomorphic-unfetch to 4.0.0 ToucanProtocol/toucan-sdk#104

Merged

pheuberger mentioned this pull request Nov 29, 2023

Change isomorphic-unfetch to track latest version again ToucanProtocol/toucan-sdk#105

Open

This was referenced Apr 23, 2024

Remove isomorphic-unfetch dependency from @appsignal/core appsignal/appsignal-javascript#622

Merged

Bump isomorphic-unfetch in @appsignal/core appsignal/appsignal-javascript#621

Closed

BohdanOne mentioned this pull request Sep 2, 2024

fix(deps): path to unpatch module prismicio/slice-machine#1453

Merged

3 tasks

fix: invalid path for export in package.json (v 5.0.0) by cristianoliveira · Pull Request #164 · developit/unfetch · GitHub

Repository navigation

fix: invalid path for export in package.json (v 5.0.0) - #164

fix: invalid path for export in package.json (v 5.0.0)#164cristianoliveira wants to merge 2 commits intodevelopit:maindevelopit/unfetch:mainfrom cristianoliveira:maincristianoliveira/unfetch:mainCopy head branch name to clipboard

Conversation

cristianoliveira commented Feb 10, 2023

Description

Demo

Solution

Relates to

Uh oh!

cristianoliveira commented Feb 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

rschristian commented Feb 15, 2023

Uh oh!

ayZagen commented Mar 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rschristian commented Mar 28, 2023

Uh oh!

denizsult commented Jun 1, 2023

Uh oh!

Skopea commented Sep 9, 2023

Uh oh!

alinasir85 commented Oct 23, 2023

Uh oh!

rschristian commented Oct 23, 2023

Uh oh!

alinasir85 commented Oct 23, 2023

Uh oh!

rschristian commented Oct 23, 2023

Uh oh!

alinasir85 commented Oct 23, 2023

Uh oh!

katerberg commented Oct 24, 2023

Uh oh!

tdacu commented Nov 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tim-kilian commented Mar 28, 2024

Uh oh!

alopix commented Aug 27, 2024

Uh oh!

katerberg commented Apr 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

fix: invalid path for export in package.json (v 5.0.0)#164
cristianoliveira wants to merge 2 commits into
developit:mainfrom
cristianoliveira:main

cristianoliveira commented Feb 10, 2023 •
edited
Loading

ayZagen commented Mar 27, 2023 •
edited
Loading

tdacu commented Nov 16, 2023 •
edited
Loading