FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Include Typescript typings in published package by resir014 · Pull Request #70 · developit/unfetch · GitHub

Repository navigation

Include Typescript typings in published package - #70

Merged
developit merged 2 commits into
developit:masterfrom
resir014:patch-1
Jul 20, 2018
Merged

developit merged 2 commits into
developit:masterfrom
resir014:patch-1

Conversation

resir014 commented Apr 30, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

This should fix Typescript projects being unable to load the included typings.

Fixes #69, #64.

This should fix Typescript projects being unable to load the included typings.

Copy link
Copy Markdown

Would be great to get this merged in. What are the next steps here?

resir014 commented May 22, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@bradleyayers Should be done, but not sure why the CI fails. Can @developit help us on this?

Edit: Also, in the meantime, you can import the entirety of isomorphic-unfetch in your entry point as a workaround.

import 'isomorphic-unfetch'

Copy link
Copy Markdown

I've just thrown a temporary declare module "unfetch"; for now, 🤞🏻this will be released soon. I came across it as this library is suggested by apollo-link-http when running under Jest.

Copy link
Copy Markdown
Contributor

@resir014 tests failing on master, so it's not just your PR :)

I think @developit is very busy. He's maintaining 100s of repos.

@developit do you need another maintainer? Willing to help out.

Copy link
Copy Markdown
Owner

That might be a good idea! My github notifications are unrecoverable at this point TBH, though this repo shouldn't be much of a maintenance burden. If anyone wants to help out (I noticed @styfle and @DanielRuf doing a bunch of lovely work!) hit me up on the preact slack or Twitter and we'll set up collaborators.

developit merged commit 13a7577 into developit:master Jul 20, 2018

Copy link
Copy Markdown
Owner

I haven't figured out what's up with the CI build, but there's no way this change is breaking so it's merge time.

Copy link
Copy Markdown
Owner

Things should be looking a little peachier now, spent an hour or two cleaning up and cut a 3.1.0 release.

Copy link
Copy Markdown
Contributor

I'll take a look today probably and check what we can improve or make better and ensure more stable and faster CI jobs.

Copy link
Copy Markdown
Contributor

The CI job is failing due to a missing space in the sanity check.

I think this was / is already fixed in master (afaik).

Copy link
Copy Markdown
Contributor

See #73.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NPM Types not working

5 participants


Back | FazBrowse Home | New Git URL