Remove node-fetch dependency for unfetch TS definition file - #98
Open
1999 wants to merge 4 commits into
Open
1999 wants to merge 4 commits into
1999 wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
|
Is there an update on this PR? |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Yep, these changes look not related. Should be fine. |
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
|
I still need to check if this is correct. We landed #117 but I don't have a TypeScript project to test things out in. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a chat in #96 I decided to remove the node-fetch imports from unfetch definition file as now it produces TS compiler errors.
isomorphic-unfetch definion stayed untouched.