This repository was archived by the owner on Sep 4, 2021. It is now read-only.
Fallback to Google Maps Web API when Geocoder does not work - #33
Open
felipemartim wants to merge 4 commits into
Open
Fallback to Google Maps Web API when Geocoder does not work#33felipemartim wants to merge 4 commits into
felipemartim wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
This fixed a baffling problem for me. Is there any reason this shouldn't be merged? |
Sorry, something went wrong.
This was referenced May 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having a problem since not all valid addresses were being geocoded properly. There were very specific addresses that the Android Geocoder would return an empty list. Because of that, and motivated by this comment, it seemed appropriate to fallback to the web API when the Geocoder returned an empty list. That fixed my issue.