This repository was archived by the owner on Sep 4, 2021. It is now read-only.
Proposal to add language parameter to get result on preferred language. (iOS only for now, but already added the function in android as well ) - #46
Open
abadikaka wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
@devfd pls review thankss :) |
Sorry, something went wrong.
itinance
reviewed
Jul 9, 2017
Comment thread
ios/RNGeocoder/RNGeocoder.h
Outdated
| @@ -1,5 +1,5 @@ | |||
| #import <React/RCTBridgeModule.h> | |||
| #import <React/RCTConvert.h> | |||
| #import "RCTBridgeModule.h" | |||
Copy link
Copy Markdown
There was a problem hiding this comment.
This will not compile >= RN 0.40
Sorry, something went wrong.
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
Ok. will update
Sorry, something went wrong.
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
@itinance btw i have put the back in latest commit, can u review on the latest commit not this one :)
Sorry, something went wrong.
fonov
approved these changes
May 21, 2018
AndrejKolar
reviewed
Jul 30, 2018
Comment thread
js/geocoder.js
| if (!this.apiKey) { throw err; } | ||
| return GoogleApi.geocodePosition(this.apiKey, position); | ||
| }); | ||
| } |
Copy link
Copy Markdown
There was a problem hiding this comment.
There is a missing , on this line which causes an unexpected token error
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
3 more reviewers4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User can put language like "en", "id", "en_US", or any formatted language code for set into user devices, then the geocoder will return result base on selected language.
Don't worry if will affect current device language. After set the language with selected language, i also put the language back to original language after get the result.
I create this after saw people had an issue on language, and i also need this feature, so i create this one.
hope will help the community :)
For now only iOS supported, but i have added the function in android as well but not yet fill the logic to change language base on the language parameter, anyone can fill in it pls fill it, while i also ask my friend who has android studio :p
Thanks ! any question pls comment or msg me abadi_kaka@yahoo.com thx