FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ci: Add Flake8 linting to notebooks by EdCaunt · Pull Request #2484 · devitocodes/devito · GitHub

ci: Add Flake8 linting to notebooks - #2484

Closed
EdCaunt wants to merge 5 commits into
mainfrom
notebook-flake8
Closed

ci: Add Flake8 linting to notebooks#2484
EdCaunt wants to merge 5 commits into
mainfrom
notebook-flake8

Conversation

EdCaunt commented Nov 13, 2024

Copy link
Copy Markdown
Contributor

@ggorman pointed out that you can now Flake8 lint Jupyter Notebooks. We should probably do this.

Copy link
Copy Markdown
Contributor

I personally wouldn't. Flake8 is really not adapted to notebooks, where readable and potentially longer lines are preferred.

EdCaunt commented Nov 13, 2024

Copy link
Copy Markdown
Contributor Author

We could always set a custom rule to ignore "line too long"

EdCaunt commented Nov 13, 2024

Copy link
Copy Markdown
Contributor Author

Looking at it, there are only about 5 "Line too long" warnings in the whole output, and most are only 5 or so characters over.

codecov Bot commented Nov 13, 2024
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.26%. Comparing base (2f18ab8) to head (be6715a).
⚠️ Report is 1078 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2484      +/-   ##
==========================================
- Coverage   87.26%   87.26%   -0.01%     
==========================================
  Files         238      238              
  Lines       45278    45271       -7     
  Branches     4022     4022              
==========================================
- Hits        39512    39505       -7     
  Misses       5085     5085              
  Partials      681      681              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mloubout added the CI continuous integration label Nov 13, 2024

Copy link
Copy Markdown

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

mloubout left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This diff is way too big for just a few line change. Also those depa should be in requirements-testing.txt not hardcoded in the yaml

EdCaunt commented Nov 18, 2024

Copy link
Copy Markdown
Contributor Author

This diff is way too big for just a few line change.

Yeah, I messed up adding the changes in one of the notebooks somehow. Will fix in due course

EdCaunt commented Nov 18, 2024

Copy link
Copy Markdown
Contributor Author

Also those depa should be in requirements-testing.txt not hardcoded in the yaml

I was just going off how the Flake8 workflow already works, can change this

Copy link
Copy Markdown
Contributor

@EdCaunt are you happy that #2813 supersedes this and we can close?

EdCaunt commented Jan 13, 2026

Copy link
Copy Markdown
Contributor Author

@JDBetteridge yeah I think so

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI continuous integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL