FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

install: Add packaging to requirements by JDBetteridge · Pull Request #2556 · devitocodes/devito · GitHub

/ devito Public

install: Add packaging to requirements - #2556

Merged
mloubout merged 1 commit into
mainfrom
JDBetteridge/fix_install
Mar 18, 2025
ConversationCommits (1)ChecksFiles changed
Merged

install: Add packaging to requirements#2556
mloubout merged 1 commit into
mainfrom
JDBetteridge/fix_install

Conversation

JDBetteridge commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

I keep getting tripped up by this every time I create a new venv

mloubout approved these changes Mar 17, 2025
View reviewed changes

mloubout left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I always thought it was default with python but yeah it keeps popping up

JDBetteridge commented Mar 17, 2025

Copy link
Copy Markdown
Contributor Author

I think it used to be included in distutils, but it's been stripped out as it's own package. Maybe everyone just assumes another package will install it 😅

codecov Bot commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.07%. Comparing base (b22dd66) to head (73f4abb).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2556      +/-   ##
==========================================
+ Coverage   87.55%   92.07%   +4.51%     
==========================================
  Files         238      238              
  Lines       47032    47032              
  Branches     4143     4143              
==========================================
+ Hits        41178    43303    +2125     
+ Misses       5161     3077    -2084     
+ Partials      693      652      -41
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 72.59% <ø> (?)
pytest-gpu-nvc-nvidiaX 73.64% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mloubout added the dependencies Pull requests that update a dependency file label Mar 18, 2025
mloubout merged commit 3efd0c0 into main Mar 18, 2025
mloubout deleted the JDBetteridge/fix_install branch March 18, 2025 01:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mloubout mloubout approved these changes
+1 more reviewer
georgebisbas georgebisbas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL