Conversation
Sorry, something went wrong.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sorry, something went wrong.
EdCaunt
left a comment
There was a problem hiding this comment.
Uncontroversial, but git add --patch is best for notebooks, otherwise it will stage all the metadata and figures if the notebook is run whilst working on the PR.
Sorry, something went wrong.
| @@ -360,19 +360,19 @@ | |||
| }, | |||
| { | |||
| "cell_type": "code", | |||
| "execution_count": 16, | |||
| "execution_count": 50, | |||
There was a problem hiding this comment.
Looks like you reran cells in different orders without resetting it.
Sorry, something went wrong.
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "norm_p = norm(p)\n", | ||
| "assert np.isclose(norm_p, .35098, atol=1e-4, rtol=0)" | ||
| "norm_p = norm(p4)\n", |
There was a problem hiding this comment.
that's the only line that needs change, you should edit tyhr ipynb as a text file and only change these two lines
Sorry, something went wrong.
There was a problem hiding this comment.
You can alternatively use git add --patch to add just the modified cells/lines
Sorry, something went wrong.
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #2565 +/- ##
=======================================
Coverage 92.00% 92.00%
=======================================
Files 244 244
Lines 47760 47760
Branches 4199 4199
=======================================
Hits 43940 43940
Misses 3149 3149
Partials 671 671
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
Tiny fix in the notebook. In the final cell it was taking the norm of p instead of p4. The norm of p is already calculated earlier in the notebook.