compiler: Fix uxreplace behaviour with numeric expressions - #2571
Merged
mloubout merged 2 commits intoApr 4, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
FabioLuporini
commented
Apr 4, 2025
Comment thread
tests/test_symbolics.py
| assert func1.p1 == (g,) | ||
| assert func1.p2 == 'bar' | ||
|
|
||
| def test_reduce_to_number(self): |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
note: this is the only new test. All other changes in this file are simply due to moving the other two uxreplace tests within the same class (so basically the diff is due to indentation)
Sorry, something went wrong.
georgebisbas
approved these changes
Apr 4, 2025
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #2571 +/- ##
=======================================
Coverage 91.99% 92.00%
=======================================
Files 244 244
Lines 47760 47774 +14
Branches 4199 4200 +1
=======================================
+ Hits 43937 43954 +17
+ Misses 3150 3149 -1
+ Partials 673 671 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
EdCaunt
approved these changes
Apr 4, 2025
mloubout
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.