FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

compiler: Blocked SubDimensions now use root dimension name by EdCaunt · Pull Request #2600 · devitocodes/devito · GitHub

/ devito Public

compiler: Blocked SubDimensions now use root dimension name - #2600

Merged
FabioLuporini merged 2 commits into
mainfrom
blocking
May 9, 2025
ConversationCommits (2)ChecksFiles changed
Merged

compiler: Blocked SubDimensions now use root dimension name#2600
FabioLuporini merged 2 commits into
mainfrom
blocking

Conversation

EdCaunt commented May 6, 2025

Copy link
Copy Markdown
Contributor

No description provided.

georgebisbas reviewed May 6, 2025
View reviewed changes
Comment thread tests/test_dimension.py Outdated
# Check generated code -- expect the gsave equation to be scheduled together
# in the same loop nest with the fsave equation
bns, _ = assert_blocking(op, {'x0_blk0', 'x1_blk0', 'ix0_blk0'})
bns, _ = assert_blocking(op, {'x0_blk0', 'x2_blk0', 'x1_blk0'})

georgebisbas May 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

wow, was not expecting this. Is it something we want?

EdCaunt May 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Tbh they could be in any order since it's a set. This change improves code readability when you have subdimensions with long names, since they can just use the name of the parent dimension

FabioLuporini May 6, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

yes

codecov Bot commented May 6, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.92%. Comparing base (3f9af54) to head (d4fb22c).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2600   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files         245      245           
  Lines       48396    48396           
  Branches     4251     4251           
=======================================
  Hits        44486    44486           
  Misses       3234     3234           
  Partials      676      676
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 72.53% <66.66%> (ø)
pytest-gpu-nvc-nvidiaX 73.59% <66.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

FabioLuporini merged commit 7c00d99 into main May 9, 2025
FabioLuporini deleted the blocking branch May 9, 2025 07:30

FabioLuporini commented May 9, 2025

Copy link
Copy Markdown
Contributor

Merged, thanks

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

FabioLuporini FabioLuporini approved these changes
+1 more reviewer
georgebisbas georgebisbas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL