Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.59%. Comparing base (1119a63) to head (a2f3b41).
Report is 2 commits behind head on main.

@@            Coverage Diff             @@
##             main    #2623      +/-   ##
==========================================
- Coverage   91.99%   87.59%   -4.41%     
==========================================
  Files         245      245              
  Lines       48495    48495              
  Branches     4261     4261              
==========================================
- Hits        44612    42477    -2135     
- Misses       3202     5297    +2095     
- Partials      681      721      +40     

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

I think it might be better to have an if-else structure which checks the PyTest version so it doesn't trip users up if they have a mismatched version

Well checks passing indicates that there aren't any tests returning non-None, so shouldn't be an issue (i.e. if this warning would come up in any prior version, then tests on the current version would fail). I imagine the warning was ignored for historical reasons and then never removed when tests were changed to not actually issue that warning

Need to update the bound on pytest in requirements-testing.txt so it catches the new version with dependabot.

Well checks passing indicates that there aren't any tests returning non-None

Can we be extra safe, enforce <8.4 (reqs above) for this PR to make sure of it, and if tests pass, update to. <8.5. From a quick search, we only have a few tests with an actual return statement, and they all return None, so it should be safe, but you never know with pytest.

All checks passing with pytest<8.4, will set the bound back to <8.5 and should be good for merge?