FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

compiler: Make cse toposort stable by mloubout · Pull Request #2633 · devitocodes/devito · GitHub

/ devito Public

compiler: Make cse toposort stable - #2633

Merged
FabioLuporini merged 1 commit into
mainfrom
safe-cse-sort
Jun 17, 2025
ConversationCommits (1)ChecksFiles changed
Merged

compiler: Make cse toposort stable#2633
FabioLuporini merged 1 commit into
mainfrom
safe-cse-sort

Conversation

mloubout commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

No description provided.

codecov Bot commented Jun 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.00%. Comparing base (ed3585a) to head (904ac28).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2633   +/-   ##
=======================================
  Coverage   92.00%   92.00%           
=======================================
  Files         245      245           
  Lines       48727    48732    +5     
  Branches     4294     4296    +2     
=======================================
+ Hits        44830    44835    +5     
  Misses       3209     3209           
  Partials      688      688
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 72.58% <0.00%> (-0.02%) ⬇️
pytest-gpu-nvc-nvidiaX 73.65% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mloubout force-pushed the safe-cse-sort branch 3 times, most recently from 3732737 to f13b249 Compare June 14, 2025 01:29
FabioLuporini changed the title compiler: make cse toposort stable compiler: Make cse toposort stable Jun 16, 2025
FabioLuporini reviewed Jun 16, 2025
View reviewed changes
Comment thread devito/passes/clusters/cse.py
FabioLuporini reviewed Jun 16, 2025
View reviewed changes
Comment thread devito/passes/clusters/cse.py
"""
Ensure the expression list is topologically sorted.
"""
if not any(isinstance(e.lhs, CTemp) for e in exprs):

FabioLuporini Jun 16, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

probably totally fine without these lines and cost of toposort without CTemps is practically zero

mloubout Jun 16, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's not much yes but still avoid building DAG and run the sorting so gains a tiny bit.

EdCaunt reviewed Jun 16, 2025
View reviewed changes
Comment thread devito/passes/clusters/cse.py
FabioLuporini reviewed Jun 16, 2025
View reviewed changes
Comment thread devito/passes/clusters/cse.py Outdated
FabioLuporini approved these changes Jun 17, 2025
View reviewed changes

FabioLuporini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Uncontroversial at this point, merging

FabioLuporini merged commit e376a0d into main Jun 17, 2025
FabioLuporini deleted the safe-cse-sort branch June 17, 2025 07:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

EdCaunt EdCaunt left review comments
FabioLuporini FabioLuporini approved these changes

Assignees

No one assigned

Labels

bug-py-minor compiler

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL