compiler: Patch IterationSpace.intersection - #2647
Merged
FabioLuporini merged 1 commit intoJun 27, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
FabioLuporini
force-pushed
the
hotfix-ispace-intersection
branch
from
b1a8c16 to
883a710
Compare
June 27, 2025 09:24
EdCaunt
approved these changes
Jun 27, 2025
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #2647 +/- ##
=======================================
Coverage 92.00% 92.00%
=======================================
Files 245 245
Lines 48787 48802 +15
Branches 4305 4307 +2
=======================================
+ Hits 44886 44900 +14
- Misses 3209 3210 +1
Partials 692 692
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
georgebisbas
approved these changes
Jun 27, 2025
mloubout
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason we never noticed it before is that we always use union in the compiler. The intersection API has always been there, but practically never used