mpi: fix multi conditional for allreduce - #2673
Merged
mloubout merged 1 commit intoJul 21, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## main #2673 +/- ##
==========================================
+ Coverage 87.65% 91.34% +3.68%
==========================================
Files 245 245
Lines 48962 49001 +39
Branches 4312 4313 +1
==========================================
+ Hits 42918 44759 +1841
+ Misses 5309 3528 -1781
+ Partials 735 714 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry.
|
Sorry, something went wrong.
Comment thread
devito/ir/clusters/algorithms.py
Outdated
EdCaunt
approved these changes
Jul 21, 2025
EdCaunt
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
One typo in a comment, but otherwise looks ok
Sorry, something went wrong.
Comment thread
tests/test_mpi.py
| name="Op") | ||
| assert_structure(op, ['t', 't,x,y', 't,x,y', 't,x,y'], 'txyxyxy') | ||
|
|
||
| # Make sure the two allreduce calls are in the time the loop |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Typo: "the time the loop" -> "the time loop"
Sorry, something went wrong.
mloubout
added a commit
that referenced
this pull request
Jul 22, 2025
mpi: fix multi conditional for allreduce
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix allreduce being attached to the wrong guards